Remove fixed wait from dev hot reload E2E

[alfonso-noriega]

WHY are these changes introduced?

Fixes N/A

The dev hot reload delete E2E test used a fixed 5 second sleep after detecting extension creation. That made the test slower and still relied on timing rather than the observable state the test already waits for.

WHAT is this pull request doing?

Removes the fixed settle wait from tests/dev-hot-reload.spec.ts before deleting the generated extension. The test now proceeds once the CLI has emitted Extension created, then deletes the extension and waits for the existing Extension deleted signal.

How to test your changes?

Validated locally from ~/worktrees/cli-remove-dev-hot-reload-fixed-wait:

pnpm install --frozen-lockfile
pnpm --filter @shopify/e2e lint
NX_SKIP_NX_CACHE=true pnpm --filter @shopify/e2e type-check
git diff --check

I did not run the full E2E spec locally because it requires E2E environment credentials.

Post-release steps

None.

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes
• I've considered analytics changes to measure impact
• This change is not user-facing, so no changeset is required

[alfonso-noriega]

• Remove fixed wait from dev hot reload E2E #7844 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.