[Tests] Replace filesystem mocks in store execute result tests#7839
[Tests] Replace filesystem mocks in store execute result tests#7839gonzaloriestra wants to merge 1 commit into
Conversation
Refactor `packages/store/src/cli/services/store/execute/result.test.ts` to use real filesystem operations via `inTemporaryDirectory` and `readFile` instead of mocking `@shopify/cli-kit/node/fs`. This ensures the tests verify actual file I/O behavior.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR refactors the unit tests for
writeOrOutputStoreExecuteResultin the@shopify/storepackage.Previously, these tests mocked the
@shopify/cli-kit/node/fsmodule to verify thatwriteFilewas called. This refactor replaces those mocks with real filesystem operations using theinTemporaryDirectoryutility and verifies the actual file content usingreadFile.Key changes:
vi.mock('@shopify/cli-kit/node/fs')frompackages/store/src/cli/services/store/execute/result.test.ts.inTemporaryDirectory.readFileto check the written content.renderSuccessis still correctly called with the appropriate file path.This improvement makes the tests more robust and less coupled to implementation details (like which specific fs function is called).
PR created automatically by Jules for task 7901792044942817499 started by @gonzaloriestra