OLD - TOCLOSE - Add dev commands for Maestro smoke flow#306
Closed
kyle-schellen wants to merge 1 commit into
Closed
Conversation
This was referenced Jun 18, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 18, 2026
kyle-schellen
force-pushed
the
06-18-add_dev_commands_for_maestro_smoke_flow
branch
from
June 22, 2026 16:16
8dc9417 to
a657071
Compare
kyle-schellen
force-pushed
the
06-17-add_shared_maestro_checkout_smoke_flow
branch
from
June 22, 2026 16:16
44cd995 to
18c150d
Compare
kyle-schellen
force-pushed
the
06-18-add_dev_commands_for_maestro_smoke_flow
branch
2 times, most recently
from
June 22, 2026 19:53
91ef9a4 to
3d87d6e
Compare
kyle-schellen
force-pushed
the
06-17-add_shared_maestro_checkout_smoke_flow
branch
from
June 22, 2026 20:02
18c150d to
c4507b6
Compare
kyle-schellen
force-pushed
the
06-18-add_dev_commands_for_maestro_smoke_flow
branch
from
June 22, 2026 20:02
3d87d6e to
476d06e
Compare
kyle-schellen
force-pushed
the
06-17-add_shared_maestro_checkout_smoke_flow
branch
from
June 22, 2026 23:30
c4507b6 to
ac66cd5
Compare
kyle-schellen
force-pushed
the
06-18-add_dev_commands_for_maestro_smoke_flow
branch
from
June 22, 2026 23:30
476d06e to
e665d1e
Compare
kyle-schellen
force-pushed
the
06-17-add_shared_maestro_checkout_smoke_flow
branch
from
June 23, 2026 12:07
ac66cd5 to
b71cc63
Compare
kyle-schellen
force-pushed
the
06-18-add_dev_commands_for_maestro_smoke_flow
branch
2 times, most recently
from
June 23, 2026 13:55
2406a8a to
c5e0368
Compare
kyle-schellen
force-pushed
the
06-17-add_shared_maestro_checkout_smoke_flow
branch
from
June 23, 2026 13:55
b71cc63 to
2ee50bf
Compare
kyle-schellen
force-pushed
the
06-17-add_shared_maestro_checkout_smoke_flow
branch
from
June 25, 2026 18:32
2ee50bf to
dd986e7
Compare
kyle-schellen
force-pushed
the
06-18-add_dev_commands_for_maestro_smoke_flow
branch
from
June 25, 2026 18:32
c5e0368 to
d6bee17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changed
Adds repo-root
dev e2ecommands for the shared Maestro checkout smoke flow:dev e2e rn-iosdev e2e rn-androiddev e2e swift-iosdev e2e androidThe React Native commands now wrap the full local setup: start Metro if needed, build/install/launch the target sample app, run Maestro, and clean up Metro if the command started it. The Swift and native Android commands route to their platform runner scripts.
Why
This makes the shared smoke flow discoverable through the repo's existing
devcommand surface instead of requiring contributors to remember platform-local script paths or manually start React Native prerequisites.Verification
dev e2e rn-iospassed end to end from a state where Metro was not already running.dev e2e swift-iospassed end to end.dev e2e androidpassed end to end on retry.dev e2e rn-androidpassed end to end using the already-installed RN Android sample app.bash -n platforms/react-native/scripts/e2e_maestro_iosbash -n platforms/react-native/scripts/e2e_maestro_android