hide communication client#288
Draft
kiftio wants to merge 1 commit into
Draft
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 16, 2026
Merged
kiftio
force-pushed
the
dk/ignore-unknown-messages
branch
from
June 16, 2026 11:51
7156a26 to
b2500fb
Compare
kiftio
force-pushed
the
06-16-hide_communication_client
branch
from
June 16, 2026 11:51
5f3a339 to
57049b1
Compare
kiftio
force-pushed
the
dk/ignore-unknown-messages
branch
from
June 16, 2026 12:24
b2500fb to
b61158a
Compare
kiftio
force-pushed
the
06-16-hide_communication_client
branch
from
June 16, 2026 12:24
57049b1 to
2d9284e
Compare
kiftio
force-pushed
the
06-16-hide_communication_client
branch
from
June 16, 2026 12:48
2d9284e to
98a13f0
Compare
kiftio
force-pushed
the
dk/ignore-unknown-messages
branch
from
June 16, 2026 12:48
b61158a to
4b0d021
Compare
kiftio
changed the base branch from
dk/ignore-unknown-messages
to
graphite-base/288
June 16, 2026 19:44
kiftio
force-pushed
the
06-16-hide_communication_client
branch
from
June 16, 2026 19:44
98a13f0 to
9229144
Compare
kiftio
changed the base branch from
graphite-base/288
to
06-16-remove_buyer_change_in_web
June 16, 2026 19:44
kiftio
force-pushed
the
06-16-hide_communication_client
branch
from
June 18, 2026 09:06
9229144 to
ee2237f
Compare
kiftio
force-pushed
the
06-16-remove_buyer_change_in_web
branch
2 times, most recently
from
June 18, 2026 10:06
0ca4dae to
af4701b
Compare
kiftio
force-pushed
the
06-16-hide_communication_client
branch
from
June 18, 2026 10:06
ee2237f to
9466b3f
Compare
kiftio
force-pushed
the
06-16-remove_buyer_change_in_web
branch
from
June 18, 2026 11:12
af4701b to
d611908
Compare
kiftio
force-pushed
the
06-16-hide_communication_client
branch
from
June 18, 2026 11:12
9466b3f to
aa6d082
Compare
kiftio
force-pushed
the
06-16-remove_buyer_change_in_web
branch
from
June 18, 2026 13:59
d611908 to
49334a2
Compare
kiftio
force-pushed
the
06-16-hide_communication_client
branch
from
June 18, 2026 13:59
aa6d082 to
0481a57
Compare
This was referenced Jun 18, 2026
kiftio
force-pushed
the
06-16-remove_buyer_change_in_web
branch
from
June 18, 2026 14:15
49334a2 to
db8403f
Compare
kiftio
force-pushed
the
06-16-hide_communication_client
branch
from
June 18, 2026 14:15
0481a57 to
a5f73e9
Compare
kiftio
force-pushed
the
06-16-remove_buyer_change_in_web
branch
from
June 18, 2026 14:54
db8403f to
46a8945
Compare
kiftio
force-pushed
the
06-16-hide_communication_client
branch
from
June 18, 2026 14:54
a5f73e9 to
09d712f
Compare
kiftio
force-pushed
the
06-16-remove_buyer_change_in_web
branch
from
June 18, 2026 15:01
46a8945 to
a604c76
Compare
kiftio
force-pushed
the
06-16-hide_communication_client
branch
from
June 18, 2026 15:01
09d712f to
3fafc47
Compare
kiftio
force-pushed
the
06-22-split_android_checkout_protocol
branch
2 times, most recently
from
June 23, 2026 13:42
598cd99 to
e45321d
Compare
kiftio
force-pushed
the
06-16-hide_communication_client
branch
2 times, most recently
from
June 23, 2026 14:09
7bd0f83 to
5c3dc6b
Compare
kiftio
force-pushed
the
06-22-split_android_checkout_protocol
branch
2 times, most recently
from
June 23, 2026 14:28
8e9f76a to
ae4461f
Compare
kiftio
force-pushed
the
06-16-hide_communication_client
branch
from
June 23, 2026 14:28
5c3dc6b to
9f5b8cc
Compare
kiftio
force-pushed
the
06-22-split_android_checkout_protocol
branch
from
June 23, 2026 15:18
ae4461f to
8bb18b2
Compare
kiftio
force-pushed
the
06-16-hide_communication_client
branch
from
June 23, 2026 15:18
9f5b8cc to
8e9c80c
Compare
kiftio
force-pushed
the
06-22-split_android_checkout_protocol
branch
from
June 23, 2026 16:10
8bb18b2 to
142dd2b
Compare
kiftio
force-pushed
the
06-16-hide_communication_client
branch
from
June 23, 2026 16:10
8e9c80c to
8a099df
Compare
kiftio
force-pushed
the
06-22-split_android_checkout_protocol
branch
from
June 23, 2026 16:14
142dd2b to
1bba215
Compare
kiftio
force-pushed
the
06-16-hide_communication_client
branch
from
June 23, 2026 16:14
8a099df to
fc9c626
Compare
kiftio
force-pushed
the
06-22-split_android_checkout_protocol
branch
from
June 23, 2026 16:24
1bba215 to
c0f407f
Compare
kiftio
force-pushed
the
06-16-hide_communication_client
branch
from
June 23, 2026 16:24
fc9c626 to
87ec0ad
Compare
kiftio
force-pushed
the
06-22-split_android_checkout_protocol
branch
from
June 23, 2026 16:32
c0f407f to
f420c55
Compare
kiftio
force-pushed
the
06-16-hide_communication_client
branch
from
June 23, 2026 16:32
87ec0ad to
2186cc3
Compare
kiftio
force-pushed
the
06-22-split_android_checkout_protocol
branch
from
June 24, 2026 08:16
f420c55 to
b2f98d6
Compare
kiftio
force-pushed
the
06-16-hide_communication_client
branch
2 times, most recently
from
June 24, 2026 08:32
1bb87a0 to
94db422
Compare
kiftio
force-pushed
the
06-22-split_android_checkout_protocol
branch
from
June 24, 2026 08:32
b2f98d6 to
5f820c4
Compare
kiftio
force-pushed
the
06-16-hide_communication_client
branch
from
June 24, 2026 08:38
94db422 to
7979938
Compare
kiftio
force-pushed
the
06-22-split_android_checkout_protocol
branch
2 times, most recently
from
June 24, 2026 09:37
0dcfa34 to
d284c1c
Compare
This was referenced Jun 24, 2026
Assisted-By: devx/6488e3d0-f47f-4171-a1c4-d2432b2a653c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changes are you making?
PR 2 - make the process method internal.
CheckoutCommunicationClient(Android) andCheckoutCommunicationProtocol(Swift/iOS) were previously public-facing interfaces that merchants could implement directly. This PR narrows their visibility tointernal/package, makingCheckoutProtocol.Clientthe sole public API for connecting typed Embedded Checkout Protocol (ECP) handlers.On Android,
CheckoutProtocol.Clientno longer implementsCheckoutCommunicationClient. Instead, an internalCheckoutProtocolClientAdapterbridges between the two, and an extension functionasCommunicationClient()is used at the boundary where the internal interface is required. All public-facing APIs (ShopifyCheckoutKit.present,CheckoutPresentation.connect,CheckoutDialog,CheckoutWebView) now acceptCheckoutProtocol.Clientdirectly.On Swift/iOS,
CheckoutCommunicationProtocolis demoted topackagevisibility. The publicpresent(checkout:from:delegate:client:)function andCheckoutViewController.init,ShopifyCheckout.connect, andAcceleratedCheckoutButtons.connectnow acceptCheckoutProtocol.Clientdirectly. Apackage-scoped overload ofpresentandconnectretaining theany CheckoutCommunicationProtocolsignature is preserved for internal use (e.g. the React Native bridge). The CocoaPodsProtocolRelayretroactive conformance ofCheckoutProtocol.ClienttoCheckoutCommunicationProtocolis removed since it is no longer needed.How to test
CheckoutProtocol.ClienttoShopifyCheckoutKit.present(Android) andpresent(checkout:from:delegate:client:)(iOS) compiles and dispatches typed callbacks correctly.CheckoutCommunicationClient/CheckoutCommunicationProtocolimplementation directly to any public API no longer compiles.CheckoutPresentationTestandEmbeddedCheckoutProtocolTest, and verify they pass.ProtocolRelayTestsuite and confirm all tests pass using the reflection-basedprocessForTesthelper.package-scoped overloads.Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/CHANGELOG.mdplatforms/swift/README.md(major version only)Releasing a new Android version?
versionNameinplatforms/android/lib/build.gradleplatforms/android/CHANGELOG.mdplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.