ldplayer: Update to version 9.5.27.0#18350
Conversation
Updated the ldplayer manifest to version 9.5.27.0 and added logic to extract the new installer format.
📝 WalkthroughWalkthroughThe LDPlayer manifest now tracks version 9.5.27.0 with updated download metadata. Update detection and automatic downloads target the setup executable. A new installer script extracts the setup payload, removes selected intermediate archives, expands remaining packages into the installation directory, and cleans up temporary files. Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
bucket/ldplayer.json (1)
26-31: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueSimplify intermediate file removal and extraction.
The script can be made more concise by combining the
Remove-Itempaths and streamlining the pipeline for the remaining.7zfiles. Adding-ErrorAction SilentlyContinueto the removal step adds resilience, ensuring the installation won't fail if the vendor omits4.7zor6.7zin a future minor update. Additionally, this fixes a trailing whitespace on line 30.♻️ Proposed refactor
- "@('4.7z', '6.7z') | ForEach-Object {", - " Remove-Item \"$dir\\installer\\$_\"", - "}", - "(Get-ChildItem \"$dir\\installer\\*.7z\").FullName | ForEach-Object {", - " Expand-7zipArchive $_ \"$dir\" ", - "}", + "Remove-Item \"$dir\\installer\\4.7z\", \"$dir\\installer\\6.7z\" -ErrorAction SilentlyContinue", + "Get-ChildItem \"$dir\\installer\\*.7z\" | ForEach-Object { Expand-7zipArchive $_.FullName \"$dir\" }",🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/ldplayer.json` around lines 26 - 31, In the installer archive cleanup block, combine the 4.7z and 6.7z removal paths into a single Remove-Item invocation and add -ErrorAction SilentlyContinue so missing vendor archives do not fail installation. Streamline the remaining .7z extraction pipeline while preserving Expand-7zipArchive behavior, and remove the trailing whitespace after its destination argument.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@bucket/ldplayer.json`:
- Around line 26-31: In the installer archive cleanup block, combine the 4.7z
and 6.7z removal paths into a single Remove-Item invocation and add -ErrorAction
SilentlyContinue so missing vendor archives do not fail installation. Streamline
the remaining .7z extraction pipeline while preserving Expand-7zipArchive
behavior, and remove the trailing whitespace after its destination argument.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 16831a9d-9ff8-4c6b-bac9-638715acf322
📒 Files selected for processing (1)
bucket/ldplayer.json
I looked at a few installers for post-9.0 versions of LDPlayer in 7-Zip File Manager to see where the files are located, and I was able to find them consistently under two specific 7z files that are obtained by running it through 7-Zip's parser mode.
Relates to #16560, #16066
-->
<manifest-name[@version]|chore>: <general summary of the pull request>