feat(models): render blueprint vars in columns dict#5845
Open
lafirm wants to merge 2 commits into
Open
Conversation
Signed-off-by: lafirm <136463254+lafirm@users.noreply.github.com>
Signed-off-by: lafirm <136463254+lafirm@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #5767 - adds support for rendering Python model columns keys (column names) and values (column types) from blueprint/global variables. Previously, column names were not rendered.
Problem
Python model metadata rendering supported macro expansion for many fields, but
columnshad gaps:columns={...}could not be parameterized (for example,@{col_name})This made blueprint-driven Python models less flexible and caused dialect validation edge cases.
What Changed
columnsfield so both:columnsin kwargs for later render-time handlingTest Plan
Docs
Updated Python model blueprinting docs with an example showing blueprint variables used for:
Validation
Ran targeted tests successfully:
python3 -m pytest tests/core/test_model.py::test_python_model_dialect -x -qpython3 -m pytest tests/core/test_model.py::test_python_model_blueprint_column_names tests/core/test_model.py::test_python_model_variable_column_names -x -qpython3 -m pytest tests/core/test_model.py -k "blueprint" -qpython3 -m pytest tests/core/test_model.py::test_python_model_dialect tests/core/test_model.py -k "column" -qBackward Compatibility
columnsdefinitions continue to work unchanged.Checklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCOReviewer Notes