Use owner-only permissions for IPC files#1705
Merged
Merged
Conversation
grantmcdermott
added a commit
to grantmcdermott/vscode-R
that referenced
this pull request
Jun 27, 2026
Apply the should-fix items from @randy3k's review of REditorSupport#1706: - Escape gc.col/gc.fill, font-family, text fill, and the raster href through svgEsc() in the SVG export builders; previously only text content was escaped, leaving these attributes injectable. - Encode large PNG exports to base64 in chunks (uint8ToBase64) instead of String.fromCharCode(...bytes), which overflows the call stack at large sizes/DPI. - Place the Unix domain socket in a private 0o700 mkdtemp directory and remove it on stop(), matching the IPC pipe handling from REditorSupport#1705. - Add a Content-Security-Policy meta tag to the JGD webview. - Set the panel icon (UriIcon 'graph') for parity with the httpgd and standard plot viewers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file artifacts created for IPC are located in the temporary folder. The files should be owner-only.