add support for abi3t#556
Conversation
|
Ping @kumaraditya303 - we were just talking about this today. |
|
I confirmed that this resolved the runtime error I reported in #555 |
| opaque_struct!(pub PyArray_Descr); | ||
|
|
||
| #[repr(C)] | ||
| pub struct PyArray_DescrProto { |
There was a problem hiding this comment.
PyArray_DescrProto should not be exposed on abi3t as numpy does.
There was a problem hiding this comment.
I think __PyArray_DescrNumPy2 needs to be defined (with ob_base removed) as this is our (only) way to access the v2 specific fields.
There was a problem hiding this comment.
For PyArray_DescrProto, what about slot 192 (PyArray_RegisterDataType) which takes it as an argument. Is it not available on abi3t and should be removed when building for it?
|
I think we should also add a check that when abi3t is used, the minimum numpy version should be 2.5. |
This adds abi3t support by
Todo:
See numpy/numpy#31091
Closes #555