Skip to content

cupshelpers: let PPDs with a blank MFG match their device #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codewiz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cupshelpers: let PPDs with a blank MFG match their device #448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions cupshelpers/ppds.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1157,12 +1157,9 @@ def _init_ids (self):
lmfg = id_dict['MFG'].lower ()
lmdl = id_dict['MDL'].lower ()

bad = False
if len (lmfg) == 0:
bad = True
# A blank MFG is legal (some devices report one); index the
# PPD under the empty make so blank-MFG device IDs can match.
if len (lmdl) == 0:
bad = True
if bad:
continue

if lmfg not in ids:
Expand Down