HotFix SaiSandeep - Fix "No comparison" filter options failing in Total Org Summary Dashboard

[saisandeepkoritala]

Description

HotFixed to make sure when we select a filter there is no error popping up. When users try to filter stats and compare them by week by week or month by month or year by year by selecting one of the options in dropdown , we get an blank page with error details.

Fix

Ensured the data passed onto the children component is rendered properly by handling all edge cases and made sure the code is reusable by extracting some portion of code into a function.

Related PRS :

Not Related to any other PR's

Main changes explained:

Made sure the data is rendered properly in children component

How to test:

1. check into current branch
2. do npm install and npm start to run this PR locally
3. Clear site data/cache
4. log as admin user
5. go to dashboard→ Reports→ Total Org Summary
6. Verify all options in "No Comparison" are working properly

Note

Still need to work on filtering data in dashboard by selected time periods. Leaving it for next dev to take it up.

Screenshots or videos of changes:

Video

CompressedVideo.mp4

[netlify]

✅ Deploy Preview for highestgoodnetwork-dev ready!

Name	Link
🔨 Latest commit	2daf776
🔍 Latest deploy log	https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/6a3a559950bfd300092354e8
😎 Deploy Preview	https://deploy-preview-5355--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[pixelpix13]

Testing Summary

Tested PR #5355 locally on the Total Org Summary page.

Verified

• Total Org Summary page loads correctly.
• No blank page appears when changing comparison filters.
• No runtime errors occur while switching filters.
• All "No Comparison" options work correctly.
• Week-over-Week comparison works correctly.
• Month-over-Month comparison works correctly.
• Year-over-Year comparison works correctly.
• Dashboard data renders correctly after changing comparison options.
• Child components render without errors.
• No regressions observed while testing the comparison filters.
• No console errors related to this functionality were observed.

Total Org Summary

---

Overall Assessment

The issue described in the PR has been resolved. Switching between the available comparison options no longer results in a blank page or rendering errors, and the dashboard updates correctly for the supported comparison modes. No issues were observed during testing.

[kzou55]

I ran and tested the PR locally.

I can verify that the No Comparison Filter Options in are functional.

• No Comparison
  

• Week Over Week
  

• Month Over Month
  

• Year Over Year
  

[Dnagabahiru]

Retested the changes on the current branch after running npm install and npm start, clearing the browser site data/cache, and logging in as an admin user. Navigated to Dashboard → Reports → Total Org Summary and verified all the options under "No Comparison".

All the "No Comparison" options are functioning as expected, and the report updates correctly when switching between them. The page loads properly, the dashboard data renders without any issues, and no blank pages or rendering problems were observed during testing.

I also checked for any regressions and monitored the browser console throughout the verification. No runtime or console errors related to this functionality were encountered.

[sundarmachani]

This PR fixes the Dropdrow as expected compared to the current code in the development branch. I’ve also noticed two headers in the development branch that I assume were added when another developer resolved merge conflicts. This change also resolved the duplication of the header on the page along with the dropdown option selection.

From Developement:

From this Current PR:

[DeepighaJ]

• Tested the PR locally.
• In light more the Vounteer status, Activites, Global distribution & Volunteer Status Overview titles are not visible need contrast improvement.
• Need improvement on the saved pdf.

pdf:

[mahathiganimi]

Hi,

I have tested these changes in my local, The functionality that this PR expects of, is working properly. However I just wanted to know if month over month, week over week, and year over year analysis is logically correct? For instance, I do not see any change in active volunteers count over years. If that is not the concern, and considering this to be mock data - Everything else looks good to me! Please confirm if that's the case.

[saisandeepkoritala]

Hi,

I have tested these changes in my local, The functionality that this PR expects of, is working properly. However I just wanted to know if month over month, week over week, and year over year analysis is logically correct? For instance, I do not see any change in active volunteers count over years. If that is not the concern, and considering this to be mock data - Everything else looks good to me! Please confirm if that's the case.

Hi mahathiganimi thanks for testing it out. I appreciate the feedback but I did include in the notes that none of filters actually filter the data, that is something that needs to be resolved and I am leaving it for a new dev to take over. The whole dashboard is unresponsive to filters so it takes more than 1 dev to sort it out. And it's something I been working on in a new PR

[saisandeepkoritala]

• Tested the PR locally.
• In light more the Vounteer status, Activites, Global distribution & Volunteer Status Overview titles are not visible need contrast improvement.
• Need improvement on the saved pdf.

pdf:

Hi Deephiga i included a video for you above in the PR from checking into branch to testing. I didn't find any issues or any duplicate headers or css issues, please let me know if you still find any issues. If you do please send me a video of all issues from checking to branch to testing, as most of the other reviewers too didnt find any issues.