Skip to content

Guard CuPy CTK extra for wheel metadata#1469

Merged
rapids-bot[bot] merged 3 commits into
NVIDIA:mainfrom
bdice:cupy-ctk-wheel-guard
Jun 30, 2026
Merged

Guard CuPy CTK extra for wheel metadata#1469
rapids-bot[bot] merged 3 commits into
NVIDIA:mainfrom
bdice:cupy-ctk-wheel-guard

Conversation

@bdice

@bdice bdice commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Contributes to rapidsai/build-planning#279

This keeps cupy-cuda12x[ctk] and cupy-cuda13x[ctk] in wheel metadata when CUDA wheels are used, while generating bare cupy-cuda12x and cupy-cuda13x metadata when use_cuda_wheels=false.

@bdice bdice requested a review from a team as a code owner June 26, 2026 14:24
@bdice bdice requested a review from gforsyth June 26, 2026 14:24
@bdice bdice added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Jun 26, 2026
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

dependencies.yaml updates the CuPy dependency matrix for requirements output and adds pyproject entries for CUDA 12 and 13 when CUDA wheels are disabled.

Changes

CuPy dependency matrix

Layer / File(s) Summary
Requirements and pyproject matrix
dependencies.yaml
depends_on_cupy changes the requirements specifiers to cupy-cuda12x>=14.0.1,!=14.1.0 and cupy-cuda13x>=14.0.1,!=14.1.0, and adds pyproject matrix entries for cuda: 12.* and cuda: 13.* with use_cuda_wheels: "false".`

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5-15 minutes

Possibly related PRs

  • NVIDIA/cuopt#1456: Also updates CuPy-related dependency specification logic in dependencies.yaml, including the cupy-cuda12x/cupy-cuda13x constraints.

Suggested reviewers

  • jameslamb
  • ramakrishnap-nv
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: guarding CuPy CTK extras in generated wheel metadata.
Description check ✅ Passed The description is directly related to the changeset and explains the metadata behavior for CUDA wheels and non-wheel mode.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@dependencies.yaml`:
- Around line 528-539: The new pyproject matrix entries in the dependency
generation config are still overlapping with the existing [ctk] pyproject rows,
so the disabled-wheel case can continue matching cupy-cuda12x/13x[ctk]. Update
the pyproject matrix rules so the [ctk] rows are explicitly gated on
use_cuda_wheels: "true", and ensure the false case only matches the non-[ctk]
packages in the same dependency definition.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a6a285ea-ad7a-40e8-a840-356369162683

📥 Commits

Reviewing files that changed from the base of the PR and between 806146e and 171076e.

📒 Files selected for processing (1)
  • dependencies.yaml

Comment thread dependencies.yaml Outdated
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

CI Test Summary

✅ All 31 test job(s) passed.

@jameslamb

Copy link
Copy Markdown
Member

/merge

@rapids-bot rapids-bot Bot merged commit dd85925 into NVIDIA:main Jun 30, 2026
93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants