MDEV-38328: Promote GitHub stars in server log and client prompt in versions 10.11 and onward#5266
Open
ottok wants to merge 1 commit into
Open
MDEV-38328: Promote GitHub stars in server log and client prompt in versions 10.11 and onward#5266ottok wants to merge 1 commit into
ottok wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Ask users to give MariaDB a star by having an extra line in the MariaDB
client prompt:
Welcome to the MariaDB monitor. Commands end with ; or \g.
Your MariaDB connection id is X
Server version: Y
Copyright (c) 2000, 2018, Oracle, MariaDB Corporation Ab and others.
Help others discover MariaDB. Star it on GitHub: https://github.com/MariaDB/server
Type 'help;' or '\h' for help. Type '\c' to clear the current input statement.
MariaDB [(none)]>
Additionally, have this extra line in server logs:
[Note] Help others discover MariaDB. Star it on GitHub: https://github.com/MariaDB/server
Test file updated with:
nano --noconvert --nonewlines mysql-test/main/mysql-interactive.result
This change is similar to 346c7af
applied on 'main', but without the SERVER_MATURITY_LEVEL check in order
to have this text visible in stable releases and actually help get the
GitHub star count up.
ottok
force-pushed
the
github-stars-promotion-10.11
branch
from
a0816fd to
f31c601
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cherry-picked from 346c7af on 'main' with the intent of having PR#4262 applied on 10.11 now, and thus on all branches maintained for the next 6 months or more. I am excluding 10.6 as it is EOL soon.
This is similar to #4262 but without the
SERVER_MATURITY_LEVELlimit in order to actually show the message to users in stable releases.