Fix DIVE config import not sticking on multicam datasets (desktop)#1781
Open
mattdawkins wants to merge 1 commit into
Open
Fix DIVE config import not sticking on multicam datasets (desktop)#1781mattdawkins wants to merge 1 commit into
mattdawkins wants to merge 1 commit into
Conversation
In multi-camera mode the importer receives the camera-qualified dataset id (`<base>/<camera>`), so an imported DIVE configuration (custom type colors, confidence thresholds, ...) was written only to that camera's meta.json. The viewer, however, loads those fields from the base dataset's metadata, so the imported values never applied or persisted. dataFileImport now also merges the mutable config keys into the base dataset's meta.json when the import targets a camera, using the same overwrite/additive datasetInfo semantics as the per-camera write. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Importing a DIVE configuration file (custom type colors, confidence thresholds, ...) works in single-camera mode but silently does nothing in multi-camera mode: neither the thresholds nor the colors apply or persist.
Cause
In multi-camera mode the desktop viewer hands the importer the camera-qualified dataset id (
<base>/<camera>), sodataFileImportwrote the config into that camera'smeta.json. The viewer, however, only readsconfidenceFilters/customTypeStyling(and the other mutable config keys) from the base dataset's metadata, so the imported values were never seen.Fix
When an import targets a camera of a multicam dataset and produces mutable-config keys,
dataFileImportnow also merges those keys into the base dataset'smeta.json, using the same overwrite/additivedatasetInfosemantics as the per-camera write. SincereloadAnnotationsre-reads the base metadata after import, the imported config now applies immediately as well.Includes a regression test covering the camera-targeted config import.
🤖 Generated with Claude Code