Skip to content

fix(local-dev): escape repoRoot in tmux new-session command - #4824

Open
FaisalMisbah23 wants to merge 1 commit into
Kilo-Org:mainfrom
FaisalMisbah23:fix/escape-reporoot-in-tmux
Open

fix(local-dev): escape repoRoot in tmux new-session command#4824
FaisalMisbah23 wants to merge 1 commit into
Kilo-Org:mainfrom
FaisalMisbah23:fix/escape-reporoot-in-tmux

Conversation

@FaisalMisbah23

Copy link
Copy Markdown
Contributor

Summary

repoRoot can contain spaces or shell-special characters (e.g. /home/user/My Projects/cloud). When passed directly to tmux new-session -c ${repoRoot}, the shell splits on the space and the command fails. This wraps it with the existing escapeForShell() utility, which is already used for all other shell-escaped values in this module.

Visual Changes

N/A dev tooling change, no UI.

Reviewer Notes

escapeForShell wraps in single quotes and handles embedded single quotes via the POSIX '\'' pattern.

@kilo-code-bot

kilo-code-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Reviewed the single-line fix wrapping repoRoot with escapeForShell() in the tmux new-session command, and it correctly prevents shell-splitting on spaces/special characters with no new issues introduced.

Files Reviewed (1 files)
  • dev/local/tmux.ts

Reviewed by claude-sonnet-5 · Input: 14 · Output: 2.1K · Cached: 256.5K

Review guidance: REVIEW.md from base branch main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant