[NET-1287] feat: Add support for google genai instrumentation #103
Open
Nithish-KV wants to merge 5 commits into
Open
[NET-1287] feat: Add support for google genai instrumentation #103Nithish-KV wants to merge 5 commits into
Nithish-KV wants to merge 5 commits into
Conversation
…from google-genai to google-generative-ai
…tant for embedding llm cals
Nithish-KV
force-pushed
the
feat/genai-sdk-instrumentation
branch
from
294aea3 to
bb31f34
Compare
| throw error; | ||
| } | ||
| }, | ||
| async return() { |
Collaborator
There was a problem hiding this comment.
Early-break return() does not close the underlying stream. Shouldn't we use iterator.return()?
| } | ||
|
|
||
| // Generation config parameters (from generationConfig object or direct kwargs) | ||
| const generationConfig = |
Collaborator
There was a problem hiding this comment.
Does Google Generative AI SDK stores generationConfig on the model instance? In wrapper.ts we only capture model, systemInstruction and history from model instance. Since kwargs.generationConfig is never set, this falls back to kwargs itself.
| { | ||
| "name": "netra-sdk", | ||
| "version": "1.4.0", | ||
| "version": "1.5.0", |
Collaborator
There was a problem hiding this comment.
Don't we need @google/genai as peerDependency?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
NetraInstruments.GOOGLE_GENAI.NetraInstruments.GOOGLE_GENERATIVE_AI.Jira
NET-1287