Give the release smoke test a display and the installed wheel#465
Merged
Conversation
First real run of the tag-triggered release path failed: the X11 backend opens a display at import time and the runner has none, so `import je_auto_control.api` raised DisplayConnectionError. The step was also importing the repo checkout rather than the wheel it had just installed — the repo root shadows site-packages on sys.path — so it never actually smoke-tested the artifact it was about to publish.
|
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first real run of the tag-triggered release path (
v0.0.215) failed inbuild, so nothing was published:Two defects in the same step, both dating from when publishing moved to
release.yml(this path had never actually run):platform-smoke.ymlinstalls xvfb for exactly this reason;release.ymldid not./home/runner/work/AutoControlGUI/AutoControlGUI/je_auto_control/...— the repo root shadows site-packages onsys.path, so the step imported the source tree, not the wheel it had just installed. It was never smoke-testing the artifact.Now runs under
xvfb-runfrom/tmpand prints the resolved__file__so a regression is visible in the log.