Fix #4239: Support more types in Extract Element node#4244
Open
Sanketjadhav31 wants to merge 1 commit into
Open
Fix #4239: Support more types in Extract Element node#4244Sanketjadhav31 wants to merge 1 commit into
Sanketjadhav31 wants to merge 1 commit into
Conversation
Fixes GraphiteEditor#4239 Added support for the following List types in the Extract Element node: - List<bool> - List<DAffine2> - List<BlendMode> - List<GradientType> - List<GradientSpreadMethod> These types are already well-supported throughout the codebase with existing conversion nodes, monitor nodes, and attribute read/write functions. This change simply exposes them in the Extract Element node's implementations list, allowing users to extract individual elements from lists of these types.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the extract_element function in node-graph/nodes/graphic/src/graphic.rs to support extracting additional list types, specifically adding support for List<bool>, List<DAffine2>, List<BlendMode>, List<GradientType>, and List<GradientSpreadMethod>. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4239
The
Extract Elementnode was missing support for a few list types that are already used elsewhere in the attribute system.This adds support for:
List<bool>List<DAffine2>List<BlendMode>List<GradientType>List<GradientSpreadMethod>These types already have existing support through attribute readers/writers and related node infrastructure, but were not included in the
Extract Elementnode's implementation list.I verified that the added types satisfy the required trait bounds and that
cargo check --package graphic-nodescompletes successfully after the change.This is a small registration-only change and does not modify the node's runtime behavior.