Guard against trimmed chain_start in TryLowWorkHeadersSync#1565
Open
tomt1664 wants to merge 2 commits into
Open
Guard against trimmed chain_start in TryLowWorkHeadersSync#1565tomt1664 wants to merge 2 commits into
tomt1664 wants to merge 2 commits into
Conversation
The trim_headers test was previously moved to extended tests, and only worked with legacy wallets. Update it to work with descriptor wallets, and move it back to base scripts in functional tests.
delta1
approved these changes
Jul 2, 2026
Contributor
|
Does this fix #1106 ? |
Member
Yes I think so |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When -trim_headers is enabled, TryLowWorkHeadersSync can receive a chain_start_header pointing to a trimmed block index entry. The
HeadersSyncStateconstructor immediately callsGetBlockHeader()on it via the m_last_header_received initialiser, which hitsassert_untrimmed()and aborts the node.Conditional untrim_to guard added inside
TryLowWorkHeadersSync, beforeHeadersSyncState.For nodes running -trim_headers, in practice the crash path is not reachable on Elements because
already_validated_workis always true on a federated chain (nChainWork == nMinimumChainWork == 0), soTryLowWorkHeadersSyncis not entered. But this ensures consistency with guarded serving paths.TryLowWorkHeadersSyncandHeadersSyncStatewere introduced in Bitcoin v24 (bitcoin/bitcoin#25717) and so this is not applicable to Elements v23.