Presolve profile#2950
Conversation
…resolve-time unit test as it's not silent
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## latest #2950 +/- ##
==========================================
- Coverage 72.96% 72.90% -0.07%
==========================================
Files 428 428
Lines 103275 102563 -712
Branches 16607 16495 -112
==========================================
- Hits 75353 74771 -582
+ Misses 27646 27516 -130
Partials 276 276 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@fwesselm This is now ready for review. It mainly implements profiling for LP presolve and improvements to the dependent equations presolve rule. However - motivated by presolving models for a client - I've also introduced the I've also added the method There's some more refactoring of presolve that I want to do in order to address #3040, but I'll do that in a separate branch. |
| } else { | ||
| // Otherwise, other entries in the pivotal column will be | ||
| // smaller than the pivot, so zero the column | ||
| zeroCol(jColPivot); |
There was a problem hiding this comment.
Is
num_active_nz_ -= mc_count_a[jColPivot];
needed before calling zeroCol?
There was a problem hiding this comment.
Yes, I would think so. Good spot!
Adds profiling of presolve and enhancement of dependent equations time-out
Dependent equations time-out is still not deterministic: see #2949