plf: remove duplicate Proof command in RecordSub.v (errors on Coq/Rocq dev)#22
Merged
bcpierce00 merged 1 commit intoJul 18, 2026
Merged
Conversation
Coq/Rocq dev now errors on multiple "Proof" commands for the same
proof ("Error: Multiple \"Proof\" commands not supported"), which
breaks compilation of RecordSub.v at substitution_preserves_typing.
Removing the redundant repeated "Proof." is backwards compatible with
all Coq versions.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019ttctspSoVoquHLQtbPVZw
Contributor
|
Merged and backported to sfdev repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written by Claude (Anthropic AI) at the request of and under the supervision of @JasonGross.
plf-current/RecordSub.vhas a literally duplicatedProof.command insubstitution_preserves_typing:Gamma |-- [x:=v]t \in T. Proof. Proof. intros Gamma x U t v T Ht Hv.Current Coq/Rocq
devrejects this outright (Error: Multiple "Proof" commands not supported.), which makes the wholeplfvolume fail to build there. This PR just removes the redundant repeatedProof., which is backwards compatible with all released Coq versions (older versions merely tolerated the duplicate).Verified that
make -C plf-currentthen completes against Rocq dev.🤖 Generated with Claude Code
https://claude.ai/code/session_019ttctspSoVoquHLQtbPVZw