Fix Repeat option not applied in CustomAnimation#865
Open
lgztx96 wants to merge 1 commit into
Open
Conversation
Author
@dotnet-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
#840
PR Type
What kind of change does this PR introduce?
Bugfix
What is the current behavior?
Since the Repeat option is not forwarded, repeatOption is null in AnimationBuilder.NormalizedKeyFrames and defaults to RepeatOption.Once.
Windows/components/Animations/src/Builders/AnimationBuilder.KeyFrames.cs
Line 345 in 9ce8a94
What is the new behavior?
CustomAnimation.AppendToBuilder now forwards the Repeat option to AnimationBuilder.NormalizedKeyFrames, allowing animations to repeat according to the configured Repeat option.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information