Skip to content

Fix Repeat option not applied in CustomAnimation#865

Open
lgztx96 wants to merge 1 commit into
CommunityToolkit:mainfrom
lgztx96:fix/animation-repeat
Open

Fix Repeat option not applied in CustomAnimation#865
lgztx96 wants to merge 1 commit into
CommunityToolkit:mainfrom
lgztx96:fix/animation-repeat

Conversation

@lgztx96

@lgztx96 lgztx96 commented Jun 28, 2026

Copy link
Copy Markdown

Fixes

#840

PR Type

What kind of change does this PR introduce?

Bugfix

What is the current behavior?

Since the Repeat option is not forwarded, repeatOption is null in AnimationBuilder.NormalizedKeyFrames and defaults to RepeatOption.Once.

What is the new behavior?

CustomAnimation.AppendToBuilder now forwards the Repeat option to AnimationBuilder.NormalizedKeyFrames, allowing animations to repeat according to the configured Repeat option.

converted (1)

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • Tests for the changes have been added (if applicable)
  • Header has been added to all new source files
  • Contains NO breaking changes

Other information

@lgztx96

lgztx96 commented Jun 28, 2026

Copy link
Copy Markdown
Author

@lgztx96 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

@dotnet-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant