Skip to content

Add a target option for simc#364

Open
ivanlele wants to merge 1 commit into
BlockstreamResearch:masterfrom
ivanlele:feature/target-cli-option
Open

Add a target option for simc#364
ivanlele wants to merge 1 commit into
BlockstreamResearch:masterfrom
ivanlele:feature/target-cli-option

Conversation

@ivanlele

Copy link
Copy Markdown
Contributor

This PR creates a new compilation option to choose a target jet set. Closes #224

@ivanlele ivanlele requested a review from delta1 as a code owner June 25, 2026 11:30
@ivanlele ivanlele force-pushed the feature/target-cli-option branch 2 times, most recently from cc8d942 to 416a8df Compare June 25, 2026 11:44
@KyrylR

KyrylR commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

needs rebase

@apoelstra

Copy link
Copy Markdown
Contributor

416a8df needs rebase

@ivanlele ivanlele force-pushed the feature/target-cli-option branch from 416a8df to 5d57119 Compare June 29, 2026 09:54
@ivanlele

Copy link
Copy Markdown
Contributor Author

Rebased

@ivanlele ivanlele force-pushed the feature/target-cli-option branch from 5d57119 to 07ce8ba Compare July 3, 2026 09:31
@ivanlele

ivanlele commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Made some improvements per @KyrylR's suggestions

@ivanlele ivanlele force-pushed the feature/target-cli-option branch from 07ce8ba to 235a814 Compare July 3, 2026 10:07

@KyrylR KyrylR left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 235a814; successfully ran local tests, code review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Overriding the Elements jet set with the --target parameter

3 participants