Overview panels#632
Merged
Merged
Conversation
Randy808
force-pushed
the
overview-panels
branch
from
dc244f5 to
0bd91d7
Compare
Collaborator
1. Adjust the display. When scrolling and clicking on the scroll bar.
2. I think it's better to use a live stopwatch rather than refresh it every couple of seconds. I don't think we need to be that precise, down to the second.
3. According to the design, the text should not be in large letters.
|
FedOken
reviewed
Jun 30, 2026
Randy808
force-pushed
the
overview-panels
branch
from
0bd91d7 to
2218b0a
Compare
FedOken
approved these changes
Jul 1, 2026
FedOken
reviewed
Jul 1, 2026
Comment on lines
+1
to
+10
| export const InfoCard = ({ | ||
| title, | ||
| tooltip, | ||
| iconSrc, | ||
| headerValue, | ||
| value, | ||
| footer, | ||
| body, | ||
| className, | ||
| } = {}) => ( |
Collaborator
There was a problem hiding this comment.
Since there isn't any strict typing here, I think it's worth checking for the availability of fields before rendering, so that the HTML markup itself will be cleaner.
if (
!title ||
!headerValue ||
!value ||
!footer
) {
return null;
}
...
<p className="info-card-header-value">{headerValue}</p>
Collaborator
Author
There was a problem hiding this comment.
I'll add this in the follow-up PR after rebase
|
私わ間違いでわないですよね🦋🇯🇵 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To run locally, npm install and use the following snippets:
Bitcoin:
Liquid:
