{CI} resourceManagement.yml sync: replace squad labels/reviewers/mentionees and route to squad teams#33682
Merged
Conversation
…ionees and route to squad teams Update ParseSquadMappingList.ps1 so squad references are replaced in place instead of appended, and so reviewers/mentionees use GitHub team form (Azure/act-*-squad) while addLabel keeps bare label form. Adds a NormalizeSquadTeamForms pass so hand-written [Squad Auto-Assign] rules also route to teams.
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
Bot
requested review from
Pan-Qi,
jsntcy,
wangzelin007 and
yonzhan
microsoft-github-policy-service
Bot
added
Auto-Assign
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the tools/Github/ParseSquadMappingList.ps1 sync script to generate .github/policies/resourceManagement.yml squad routing in a more deterministic way, aiming to avoid accumulating stale squad label/reviewer/mentionee entries and to emit GitHub team-form values for reviewers/mentionees.
Changes:
- Adds helpers to identify squad values, convert team-form to label-form, and normalize bare squad reviewers/mentionees to
Azure/<team>form. - Refactors
AddSquadLabelsToYamlto update existing squad label/reviewer/mentionee lines in-place and insert additional ones when needed. - Adds a final
NormalizeSquadTeamFormspass so hand-written[Squad Auto-Assign]rules also get normalized to team form.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (-not [string]::IsNullOrWhiteSpace($condLabel)) { | ||
| $labelsPresent[$condLabel] = $true | ||
| } | ||
| $labelsFromConditions = GetLabelsFromConditions -Lines $Lines -ThenLineIndex $i -BaseIndentLength $baseIndentLength |
Comment on lines
+430
to
+433
| for ($p = $i - 1; $p -ge 0; $p--) { | ||
| if ($Lines[$p] -match '^\s*description:') { break } | ||
| if ($Lines[$p] -match 'payloadType:\s*Pull_Request') { $isPR = $true; break } | ||
| } |
Comment on lines
+435
to
+446
| $labelExtraLines = [System.Collections.Generic.List[string]]::new() | ||
| for ($t = 0; $t -lt $targets.Count; $t++) { | ||
| $squadLabel = ToSquadLabel -Squad $targets[$t] | ||
| if ($t -lt $addLabelSquadLines.Count) { | ||
| $lineIndex = $addLabelSquadLines[$t] | ||
| $indent = " " * (GetIndentLength -Line $work[$lineIndex]) | ||
| $work[$lineIndex] = "${indent}label: $squadLabel" | ||
| } elseif ($lastAddLabelLine -ge 0) { | ||
| $labelExtraLines.Add((" " * $listIndentLength) + "- addLabel:") | ||
| $labelExtraLines.Add((" " * $listIndentLength) + " label: $squadLabel") | ||
| } | ||
| } |
Collaborator
|
CI |
wangzelin007
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
This is a CI/automation tooling change (no
azcommand surface). It updates the script that syncs the ADO Wiki Squad Mapping table into.github/policies/resourceManagement.yml.Description
Updates
tools/Github/ParseSquadMappingList.ps1so squad routing is written correctly and deterministically:mentioneesandreviewervalues are emitted in GitHub team form (Azure/act-*-squad) so they can actually be @mentioned and assigned.addLabelandhasLabeldeliberately stay in bare label form (act-*-squad), since those require a label, not a team.NormalizeSquadTeamFormspass normalizes squad reviewers/mentionees to team form everywhere including the hand-written auto-assign rules that are keyed on a squad label and are therefore not driven by the wiki mapping.Testing Guide
Ran the script locally against the live ADO Wiki and audited the generated
resourceManagement.yml:This checklist is used to make sure that common guidelines for a pull request are followed.