Skip to content

chore: remove 3 dead tool-name converters + fix unused-arg lint warnings in runtime-artifact-conversion.cts #1175

@trek-e

Description

@trek-e

Pre-submission checklist

  • This does not change user-facing behavior (commands, output, file formats, config)
  • I have searched existing issues — this has not already been filed

What is the maintenance task?

Clear 4 of the 12 @typescript-eslint/no-unused-vars warnings in src/runtime-artifact-conversion.cts that are pure lint hygiene: delete 3 genuinely-dead functions and rename 1 signature-placeholder argument.

Type of maintenance

Refactoring / code quality

Current state

npm run lint emits 12 no-unused-vars warnings in src/runtime-artifact-conversion.cts. Investigation split them into three buckets; this issue covers the 4 trivially-correct ones (the other 8 are an unwired-migration gap tracked in #1173):

  • 3 genuinely deadconvertCursorToolName, convertWindsurfToolName, convertAugmentToolName. No call site in src/runtime-artifact-conversion.cts or bin/install.js; the corresponding agent converters perform tool-name mapping inline (regex) and never call these. Orphaned in both source and the generated installer.
  • 1 signature placeholder — the runtime arg of convertClaudeCommandToClineSkill (~line 1508). All skill converters share the 5-arg signature (content, skillName, runtime, cmdNames, isGlobal); Cline needs no runtime branching so the arg is unused. Lines ~326–327 already use the _-prefix convention for exactly this case.

Warnings are deferred errors; suppressing without understanding is not acceptable — these 4 are honestly resolvable (delete what's dead, follow the existing _-prefix convention for a real placeholder).

Proposed work

  • Delete convertCursorToolName, convertWindsurfToolName, convertAugmentToolName from src/runtime-artifact-conversion.cts (and from bin/install.js if it is hand-maintained rather than generated from the .cts).
  • Rename the unused runtime arg of convertClaudeCommandToClineSkill to _runtime, matching the established convention.
  • Rebuild (npm run build) and confirm the lint warning count drops by 4 (12 → 8, the remaining 8 owned by enhancement: wire the 8 extracted agent converters into the descriptor-driven install path (ADR-457 follow-up to #1099) #1173).
  • Confirm no behavior change (runtime conversion tests stay green; gsd-test docker green).

Done when

  • The 3 dead convert*ToolName functions are removed from source (and generated installer)
  • convertClaudeCommandToClineSkill's placeholder arg is _runtime
  • npm run lint shows 8 warnings in that file (down from 12), 0 errors
  • gsd-test docker green; no user-facing change

Area affected

Core library code

Additional context

Surfaced during the #1170 lint review. Companion to #1173 (which wires the remaining 8 agent converters). Splitting keeps one-concern-per-pr: this is mechanical hygiene; #1173 is a behavioral migration.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions