Skip to content

Commit 987c959

Browse files
Fix copilot NOTICE file generation when publishing (#317415)
VSCODE_PUBLISH is a pipeline variable defined in product-build.yml and is not accessible from included templates at compile-time. Pass it as a template parameter, matching how VSCODE_RELEASE is plumbed through. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent f6cfa2e commit 987c959

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

build/azure-pipelines/product-build.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -224,6 +224,7 @@ extends:
224224
jobs:
225225
- template: build/azure-pipelines/product-copilot.yml@self
226226
parameters:
227+
VSCODE_PUBLISH: ${{ variables.VSCODE_PUBLISH }}
227228
VSCODE_RELEASE: ${{ parameters.VSCODE_RELEASE }}
228229

229230
- ${{ if eq(variables['VSCODE_BUILD_STAGE_WINDOWS'], true) }}:

build/azure-pipelines/product-copilot.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
parameters:
2+
- name: VSCODE_PUBLISH
3+
type: boolean
4+
default: false
25
- name: VSCODE_RELEASE
36
type: boolean
47
default: false
@@ -35,7 +38,7 @@ jobs:
3538
- template: copilot/build-steps.yml
3639
- template: copilot/l10n-steps.yml
3740

38-
- ${{ if or(eq(variables['VSCODE_PUBLISH'], true), eq(parameters.VSCODE_RELEASE, true)) }}:
41+
- ${{ if or(eq(parameters.VSCODE_PUBLISH, true), eq(parameters.VSCODE_RELEASE, true)) }}:
3942
- task: notice@0
4043
inputs:
4144
outputfile: $(Build.SourcesDirectory)/extensions/copilot/ThirdPartyNotices.txt

0 commit comments

Comments
 (0)