refactor(pypi): make whl_library a macro and split impl into whl_archive and pip_archive#3948
Open
aignas wants to merge 12 commits into
Open
refactor(pypi): make whl_library a macro and split impl into whl_archive and pip_archive#3948aignas wants to merge 12 commits into
aignas wants to merge 12 commits into
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Collaborator
Author
|
/review |
Collaborator
|
argh, what the heck, it went totally awol and borked this. I'll reset and fix it. |
rickeylev
force-pushed
the
aignas.refactor.macro_whl_library
branch
from
July 24, 2026 16:17
ecff978 to
db4f499
Compare
Rename internal repository implementation function _whl_library_impl to _pip_archive_impl to match the pip_archive repository rule name.
rickeylev
approved these changes
Jul 24, 2026
rickeylev
enabled auto-merge
July 24, 2026 16:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR the
whl_librarywould be a do-all repository rule. Whilst itis convenient to reuse the code, it is actually really difficult to maintain
and make it more performant. Side effect here is that the python dependencies
(like
setuptools, etc) will no longer be downloaded for whl-only extracts,it makes it a tiny bit faster.
With this split we can drop certain dependencies from the whl extraction and
optimize the common path - whl extraction where the URL for downloading the
wheel is known. This also allows us to start handling the sdists in an entirely
different way.
In a followup PR I plan to split the part which just extracts the wheel to
lay a more surgical foundation to #3856.
Foundation work for #2410.
Split out of #3856.
Work towards #2948.