Skip to content

Keep backward-compatible mode IDs for Goose (auto / smart-approve / approve / chat) #264

Description

@wangkang

Goose codex-acp integration still uses legacy mode values, but @agentclientprotocol/codex-acp now only accepts:
read-only, agent, agent-full-access.

So Goose sessions that still send GOOSE_MODE=auto (default) or smart-approve/approve/chat fail with invalidParams when mode is set/updated.

Observed in code:

  • agentclientprotocol/codex-acp:
    • src/AgentMode.ts: AgentMode.all() only returns 3 IDs above; find() is exact-match only.
    • src/CodexAcpServer.ts: setSessionMode/setSessionConfigOption call applyModeChange, which rejects unknown mode IDs.
  • Goose:
    • crates/goose/src/providers/codex_acp.rs: legacy mapping (GooseMode::Auto -> danger-full-access and map entries Auto -> "full-access", SmartApprove -> "auto", etc.).
    • Goose docs still reference old package @zed-industries/codex-acp.

Request: please add compatibility mapping (e.g. auto/full-access -> agent-full-access, smart-approve -> agent, approve/chat -> read-only) with deprecation notice, to avoid breaking existing Goose users during migration.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions